Skip to content

Bug fix STUD-771: updated grading help text... - #1373

Merged
frrrances merged 2 commits into
masterfrom
frances/fix/studio-grading-helptext
Oct 17, 2013
Merged

Bug fix STUD-771: updated grading help text...#1373
frrrances merged 2 commits into
masterfrom
frances/fix/studio-grading-helptext

Conversation

@frrrances

Copy link
Copy Markdown
Contributor

I updated the help text on the Weight of the Total Grade to be more clear that it should be an integer without the percent sign. Fixes bug STUD-771. @cahrens and @talbs can you review?

…hat it should be an integer without the percent sign
@cahrens

cahrens commented Oct 16, 2013

Copy link
Copy Markdown

Can you wrap the user-visible text with gettext() also? For an example, see /edx-platform/cms/templates/js/edit-textbook.underscore.

@cahrens

cahrens commented Oct 16, 2013

Copy link
Copy Markdown

Can I be even greedier? I just noticed that there is no space between + and "New Assignment Type" at the bottom of the grading page.

@frrrances

Copy link
Copy Markdown
Contributor Author

Well, okay. I noticed that missing space and decided I wouldn't risk touching another file. But it makes me happy to fix it. Labels and tip text in that file should also be i18n now.

@cahrens

cahrens commented Oct 17, 2013

Copy link
Copy Markdown

👍

@talbs

talbs commented Oct 17, 2013

Copy link
Copy Markdown
Contributor

👍

frrrances pushed a commit that referenced this pull request Oct 17, 2013
Bug fix STUD-771: updated grading help text...
@frrrances
frrrances merged commit 9f5bd4e into master Oct 17, 2013
@frrrances
frrrances deleted the frances/fix/studio-grading-helptext branch October 17, 2013 14:42
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Nov 14, 2016
giovannicimolin pushed a commit to open-craft/openedx-platform that referenced this pull request Feb 9, 2019
MCKIN-9463: bump xblock-ooyala version to v2.0.22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants